[api] historical eth_getbalance & eth_call #4339
Open
+591
−180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
envestcc
requested review from
CoderZhi,
dustinxie,
Liuhaai and
a team
as code owners
dustinxie
reviewed
Jul 23, 2024
api/coreservice.go
Outdated
| case rpc.SafeBlockNumber, rpc.FinalizedBlockNumber, rpc.LatestBlockNumber: | ||
| stateHeight = core.bc.TipHeight() | ||
| case rpc.EarliestBlockNumber: | ||
| stateHeight = core.bc.Genesis().EasterBlockHeight |
There was a problem hiding this comment.
why it is easter height? it should be 1
dustinxie
reviewed
Jul 23, 2024
| @@ -367,8 +368,8 @@ func (svr *gRPCHandler) ReadContract(ctx context.Context, in *iotexapi.ReadContr | |||
| return nil, status.Error(codes.InvalidArgument, err.Error()) | |||
| } | |||
| sc.SetGasLimit(in.GetGasLimit()) | |||
|
|
|||
| data, receipt, err := svr.coreService.ReadContract(ctx, callerAddr, sc) | |||
| sc.SetGasPrice(big.NewInt(0)) // ReadContract() is read-only, use 0 to prevent insufficient gas | |||
There was a problem hiding this comment.
can this be omitted? I mean, by default it should be 0?
dustinxie
reviewed
Jul 23, 2024
| @@ -399,7 +404,8 @@ func (svr *web3Handler) call(in *gjson.Result) (interface{}, error) { | |||
| return "0x" + ret, nil | |||
| } | |||
| exec, _ := action.NewExecution(to, 0, value, gasLimit, gasPrice, data) | |||
| ret, receipt, err := svr.coreService.ReadContract(context.Background(), callerAddr, exec) | |||
| exec.SetGasPrice(big.NewInt(0)) // ReadContract() is read-only, use 0 to prevent insufficient gas | |||
There was a problem hiding this comment.
the gasPrice may not be 0, because it can be set by the action sender
|
CoderZhi
requested changes
Aug 1, 2024
Comment on lines
+111
to
+112
| func AccountStateAtHeight(ctx context.Context, height uint64, sr protocol.HistroicalStateReader, | ||
| addr address.Address) (*state.Account, error) { |
| @@ -350,6 +404,7 @@ func (core *coreService) Account(addr address.Address) (*iotextypes.AccountMeta, | |||
| accountMeta.ContractByteCode = code | |||
| } | |||
| span.AddEvent("bc.BlockHeaderByHeight") | |||
| tipHeight := core.bc.TipHeight() | |||
There was a problem hiding this comment.
the tipHeight may be from a different value from state read from https://github.com/iotexproject/iotex-core/pull/4339/files#diff-a84e0d7fdb009bebf88eb3c2582dc4c2f5fce09f6d40a3a514b553c198675f42R373
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
as title
Fixes #(issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: